From 7889b0717f1283a2b2f1822a865ad409a24be5bc Mon Sep 17 00:00:00 2001
From: Robert Scholte <rfscholte@apache.org>
Date: Thu, 4 Oct 2012 21:22:17 +0000
Subject: [PATCH] Add @since + generics

git-svn-id: file:///home/tiste/MOJOHAUS-TO-GIT/SVN-MOJO-WIP/trunk/mojo/clirr-maven-plugin@17631 52ab4f32-60fc-0310-b215-8acea882cd1b
---
 .../java/org/codehaus/mojo/clirr/Difference.java   | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/src/main/java/org/codehaus/mojo/clirr/Difference.java b/src/main/java/org/codehaus/mojo/clirr/Difference.java
index af1601e..a40400a 100644
--- a/src/main/java/org/codehaus/mojo/clirr/Difference.java
+++ b/src/main/java/org/codehaus/mojo/clirr/Difference.java
@@ -20,7 +20,6 @@ import java.io.File;
 import java.io.IOException;
 import java.io.Reader;
 import java.util.ArrayList;
-import java.util.Iterator;
 import java.util.List;
 
 import net.sf.clirr.core.ApiDifference;
@@ -35,6 +34,7 @@ import org.codehaus.plexus.util.xml.pull.XmlPullParserException;
  * A specification of a ignored difference found by Clirr.
  * 
  * @author Lukas Krejci
+ * @since 2.5
  */
 public class Difference
 {
@@ -95,7 +95,7 @@ public class Difference
         XmlPullParser parser = new MXParser();
         parser.setInput( xml );
 
-        ArrayList diffs = new ArrayList();
+        List<Difference> diffs = new ArrayList<Difference>();
 
         int state = 0;
         int event;
@@ -461,7 +461,7 @@ public class Difference
         }
     }
 
-    public boolean resolveDefferedMatches( List defferedApiDifferences )
+    public boolean resolveDefferedMatches( List<ApiDifference> defferedApiDifferences )
     {
         if ( differenceType == 7005 )
         {
@@ -702,11 +702,11 @@ public class Difference
     /**
      * Method Argument Type changed
      */
-    private boolean matches7005( List apiDiffs )
+    private boolean matches7005( List<ApiDifference> apiDiffs )
     {
         throwIfMissing( false, true, false, true );
 
-        ApiDifference firstDiff = (ApiDifference) apiDiffs.get( 0 );
+        ApiDifference firstDiff = apiDiffs.get( 0 );
 
         String methodSig = removeVisibilityFromMethodSignature( firstDiff );
 
@@ -716,10 +716,8 @@ public class Difference
         }
 
         String newType = methodSig;
-        for ( Iterator i = apiDiffs.iterator(); i.hasNext(); )
+        for ( ApiDifference apiDiff : apiDiffs )
         {
-            ApiDifference apiDiff = (ApiDifference) i.next();
-
             String[] args = getArgs( apiDiff );
 
             // 1-based
-- 
GitLab